Ok, you are right, not all rules are useful :wink:
After the first run over all assebmlies an the compiled page the tool found over 14000 issues. Then I disabled a few rules :arrow: "only" 1500. As you can see in my analysis of the report file, the most problems came from Globalization rules
Issue count
TypeName # of issues
SpecifyIFormatProvider 727
DoNotInitializeUnnecessarily 114
SpecifyCultureInfo 107
DoNotCatchGeneralExceptionTypes 63
DoNotDeclareVisibleInstanceFields 57
TestForEmptyStringsUsingStringLength 47
SpecifyStringComparison 41
DoNotRaiseReservedExceptionTypes 34
ReviewUnusedParameters 34
UsePropertiesWhereAppropriate 31
SetLocaleForDataTypes 23
UseLiteralsWhereAppropriate 20
DoNotExposeGenericLists 19
DoNotCastUnnecessarily 18
ConsiderPassingBaseTypesAsParameters 17
DoNotPassTypesByReference 17
GenericMethodsShouldProvideTypeParameter 17
OperatorOverloadsHaveNamedAlternates 16
ImplementIDisposableCorrectly 13
RemoveUnusedLocals 13
AptcaMethodsShouldOnlyCallAptcaMethods 10
PropertiesShouldNotBeWriteOnly 10
CollectionPropertiesShouldBeReadOnly 8
EventsShouldNotHaveBeforeOrAfterPrefix 8
CallGCSuppressFinalizeCorrectly 7
ParameterNamesShouldMatchBaseDeclaration 7
NonConstantFieldsShouldNotBeVisible 6
PropertiesShouldNotReturnArrays 5
AvoidUncalledPrivateCode 4
DoNotIgnoreMethodResults 4
InterfaceMethodsShouldBeCallableByChildTyp 4
DoNotHardcodeLocaleSpecificStrings 3
ReviewVisibleEventHandlers 3
UseEventsWhereAppropriate 3
AvoidOutParameters 2
AvoidUnusedPrivateFields 2
DeclareEventHandlersCorrectly 2
DoNotDeclareReadOnlyMutableReferenceTypes 2
DoNotDeclareStaticMembersOnGenericTypes 2
OverrideLinkDemandsShouldBeIdenticalToBase 2
PropertyNamesShouldNotMatchGetMethods 2
DoNotCallOverridableMethodsInConstructors 1
IdentifiersShouldHaveCorrectSuffix 1
InitializeReferenceTypeStaticFieldsInline 1
MembersShouldNotExposeCertainConcreteTypes 1
Total for YAF 1528
Give me 3 months of hollidays, stop your developement of YAF and I will make a very big patch :lol: 😛 :lol:
Sorry I can not upload the report file in this forum
Edited by user
2009-10-11T17:51:05Z
|
Reason: No Upload